Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing header to sample #22242

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Adding missing header to sample #22242

merged 1 commit into from
Jan 19, 2023

Conversation

kayousef
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-workflow-bot
Copy link

Hi, @kayousef Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @kayousef kayousef requested review from BlackRider97 and rysweet and removed request for a team January 19, 2023 09:42
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-net-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from ac0c2286c4920e34e21d6af3d5d4ee52ef01bb5d. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from ac0c2286c4920e34e21d6af3d5d4ee52ef01bb5d. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.3.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.3.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Cognitive Services label Jan 19, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @kayousef kayousef closed this Jan 19, 2023
    @kayousef kayousef reopened this Jan 19, 2023
    @jhendrixMSFT jhendrixMSFT merged commit 76f8376 into Azure:kayousef/language/2023-04-01 Jan 19, 2023
    jhendrixMSFT added a commit that referenced this pull request Jan 19, 2023
    @AhmedLeithy @kayousef @jhendrixMSFT
    Rename Language 2023-05-01 to 2023-04-01 (#21990)
    deba715 
    * Rename Language 2023-05-01 to 2023-04-01

* Adding missing header to sample (#22242)

Co-authored-by: Kareem Yousef <[email protected]>
Co-authored-by: Kareem Yousef <[email protected]>
Co-authored-by: Joel Hendrix <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @annatisch annatisch Awaiting requested review from annatisch

    @heaths heaths Awaiting requested review from heaths

    @deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

    @kristapratico kristapratico Awaiting requested review from kristapratico

    @mssfang mssfang Awaiting requested review from mssfang

    @BlackRider97 BlackRider97 Awaiting requested review from BlackRider97 BlackRider97 was automatically assigned from Azure/api-stewardship-board

    @rysweet rysweet Awaiting requested review from rysweet rysweet was automatically assigned from Azure/api-stewardship-board

    Assignees
    No one assigned
    Labels
    Cognitive Services
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @kayousef @jhendrixMSFT